-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Standard Schema validator to Qwik Router #7281
base: build/v2
Are you sure you want to change the base?
feat: Add Standard Schema validator to Qwik Router #7281
Conversation
|
Please give me feedback on the changes and implementation. Once everything looks good and it is planned to merge the PR, I (or someone else) can update tests and docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haven't looked closely yet, but we should have type tests in the unit tests
Any updates on this? Would very much like to be using ArkType with Qwik through this Standard Schema support! Edit: seems some of the tests need to be updated for the |
What is it?
Description
I implemented a
schema$
validator function based on Standard Schema that should replacezod$
andvalibot$
in the long run.New features:
schema$
function that supports any Standard Schema copatiple schema library including Zod, ArkType and ValibotBreaking changes:
z
.fieldErrors
array[].key
toarray.${number}.key
Other changes:
zod$
andvalibot$
as well as any directly related functions and typesvalibot$
as it was in@beta
stage and marked as experimentalChecklist
pnpm change